6,851

(6 replies, posted in PunBB 1.2 troubleshooting)

Well, you'll have to undo whatever damage he did (which seems basically to be changing all the forum names/descriptions and the board name/description) and then delete his account (or just remove his admin status)

My theory: this happens when there's a bit of lag on the server. This means that when the player goes to login, it's slow, so he refreshes the page a couple times. All the SELECT queries end up getting done before the INSERT, so the online entry is inserted x number of times.
My idea to fix:
1. FIND

            // Update the online list
            if (!$pun_user['logged'])
                $db->query('INSERT INTO '.$db->prefix.'online (user_id, ident, logged) VALUES('.$pun_user['id'].', \''.$db->escape($pun_user['username']).'\', '.$now.')') or error('Unable to insert into online list', __FILE__, __LINE__, $db->error());

REPLACE WITH

            // Update the online list
            if (!$pun_user['logged'])
                $db->query('REPLACE INTO '.$db->prefix.'online (user_id, ident, logged) VALUES('.$pun_user['id'].', \''.$db->escape($pun_user['username']).'\', '.$now.')') or error('Unable to insert into online list', __FILE__, __LINE__, $db->error());

FIND

    // Update online list
    if (!$pun_user['logged'])
        $db->query('INSERT INTO '.$db->prefix.'online (user_id, ident, logged) VALUES(1, \''.$db->escape($remote_addr).'\', '.time().')') or error('Unable to insert into online list', __FILE__, __LINE__, $db->error());

REPLACE WITH

    // Update online list
    if (!$pun_user['logged'])
        $db->query('REPLACE INTO '.$db->prefix.'online (user_id, ident, logged) VALUES(1, \''.$db->escape($remote_addr).'\', '.time().')') or error('Unable to insert into online list', __FILE__, __LINE__, $db->error());

2. Add a compound unique index on user_id and ident.

Basically, this ensures that there will never be more then one online entry for the same user_id and ident.

6,853

(8 replies, posted in PunBB 1.2 bug reports)

I found one way to cause this.
Here's what I did with my test board:
1. Make 1 more post then my max topics per page (30 in my case, the default)
2. Go to 'Show new posts since last visit'
3. Go to the second page.
4. Delete one thread
5. Click the first page link again.

Basically, because it uses a search id, it loads results from back when there were 31 topics and uses that as num_hits but only fetches the 30 that still exist.
I'd say the best fix would be to not use num_hits from the t.id count, but instead from the actual query you do form the search (just grab $db->num_rows for that).

6,854

(10 replies, posted in PunBB 1.2 troubleshooting)

According to my google search, mod_security can cause that

6,855

(6 replies, posted in PunBB 1.2 troubleshooting)

you can md5/sha1 directly in MySQL as well

update tablename set password = md5(password)
or
update tablename set password = sha1(password)

6,856

(71 replies, posted in Feature requests)

Arvid: http://www.punres.org/viewtopic.php?id=541 does have that feature afaik

6,857

(9 replies, posted in General discussion)

I would email Chacmool a dump of the database and see if he could add it to the Convertor as well wink

shinko_metsuo wrote:
punres wrote:

Since we had ~5500 "fake" users with 0 posts, I've now removed all users with 0 posts. Your account may therefor have been removed.

I apologize for the inconvenience

You could have been on of the ones that were deleted. Delete your cookies set by punres and try it. I can get in just fine.

He accidentally deleted the Guest user as well smile

Mmm, because I was logged in!

6,860

(2 replies, posted in PunBB 1.2 troubleshooting)

It's only shown for mods and admins wink

Seems to be fixed now

ultime: It needs more then one query wink

6,863

(5 replies, posted in PunBB 1.2 troubleshooting)

If you modded the files, then you'd have issues with your mods not working
Other then that, editing should work fine (use the hdiff)

I'll see what I can do for a plugin (there shouldn't be as many issues as you think).

Edit: mmm, I lied, there's more then just updating posts, there's also topics

6,865

(5 replies, posted in PunBB 1.2 troubleshooting)

Well, I don't think your host supports PHP

6,866

(3 replies, posted in PunBB 1.2 bug reports)

You have 2 else's in a row

And when I changed it slightly I got this:

Warning: dl(): Not supported in multithreaded Web servers - use extension statements in your php.ini in c:\apache\htdocs\upload\admin_index.php on line 91

Fatal error: Cannot instantiate non-existent class: win32 in c:\apache\htdocs\upload\admin_index.php on line 92


And enabling that dll file killed Apache when I tried to load the admin index page smile

The default is disabled, and it only works on topics posted while it's enabled

6,868

(3 replies, posted in PunBB 1.2 troubleshooting)

Mmm, I really should pay more attention to the address (I didn't realize it was MyPunBB, somehow) tongue
Talk to Connor, like he said in the other thread you must have messed with admin.tpl

6,869

(3 replies, posted in PunBB 1.2 troubleshooting)

Without seeing the code it's impossible to tell what he has done wink

6,870

(34 replies, posted in General discussion)

InuKalriko wrote:

There are actually good crackers. I hate it when people get hackers and crackers confused as one and the same. Let me break it down for all you people who don't seem to notice the difference.

Hacker: breaks into sites and servers with the intent of causing harm.

Crackers: breaks into sites and servers to find flaws. Most report said flaws to the owner of the site/server.

It's very easy to mistake one for the other as most people don't have a very good notion of either. I have a friend thats a cracker and he makes a lot of money (and in the case of game servers sometimes a free subscription) for his help in finding security flaws. On the other hand he gets threatened with a few police phone calls sometimes too but the people don't realize he's trying to help. Thats just my oppinion.

You have them confused wink
Cracker definition

# A cracker is one who engages in one or more of the following: 1) breaks into a computer system; 2) figures out ways to bypass security or license protection in software; 3) intentionally breaches computer security. Contrary to popular belief, Cracker is not synonymous with Hacker.
practice.findlaw.com/glossary.html

# A malicious hacker. Top
www.smoothwall.net/support/glossary.html

6,871

(8 replies, posted in Feature requests)

Well, you would input an IP range I assume and check the user's IP against that

6,872

(8 replies, posted in Feature requests)

You do that anyway for the login table tongue
I can't see a performance hit in doing that wink

6,873

(6 replies, posted in PunBB 1.2 bug reports)

What if you're trying to ban someone because they do something like check extern.php on every pageview, rather then caching it? wink
The only way in that situation someone would be banned is if they were banned by IP.

And if I understand 1.3's extern.php correctly, you'll be able to view threads through it (correct me if I'm wrong): wouldn't it defeat the point of banning if they can read the forum anyway?

6,874

(1 replies, posted in PunBB 1.2 bug reports)

extern.php has error reporting set to E_ALL. It should be set to E_ALL ^ E_NOTICE (like common.php is)

6,875

(2 replies, posted in PunBB 1.2 troubleshooting)

http://www.punres.org/viewtopic.php?id=188
I'm not sure if it supports VB or not