Looks fine to me...

7,202

(7 replies, posted in PunBB 1.2 discussion)

I would also ask Chacmool about it, if you give him a dump of the database he should be able to add the functionality to the covertor

7,203

(6 replies, posted in PunBB 1.2 troubleshooting)

Well, that wouldn't be a fresh install, that would be a conversion using an older version of the convertor (it should be fixed now)

Erm, I think that has an SQL inject in it smile

Edit: I'm talking about the exclusion

Notice the extra < at the beginning of the <div> tag? Delete it wink

7,206

(26 replies, posted in PunBB 1.2 discussion)

LOL tongue
Poor Rickard smile

7,207

(25 replies, posted in Feature requests)

That's a group option in 1.2 I think smile

7,208

(9 replies, posted in Feature requests)

Mmm, I do remember something like that being a problem, let me search

http://punbb.org/forums/viewtopic.php?id=6355

Paul wrote:

Actually it is really both reasons. The target attribute is not XHTML compliant and the reason it is not compliant is that browser behaviour is not something that is the business of markup or css; thats what javascript is for. There is another reason and that is there are accessability issues with opening links in new windows.  I think you will find that during the next couple of years opening links in new windows will become something of a rarity.

7,209

(9 replies, posted in Feature requests)

Which, I believe, isn't valid markup smile

7,210

(2 replies, posted in PunBB 1.2 discussion)

Already done wink
http://www.mypunbb.com/
And I must say, it pwns tongue

7,211

(2 replies, posted in PunBB 1.2 bug reports)

Rickard wrote:

IMPORTANT: Two rather annoying bugs have surfaced since the release of 1.2.5. See this post for instructions on how to fix them.

7,212

(5 replies, posted in Feature requests)

Yeah, I know wink
And to say again something I think Paul brought up: you don't have to make the system overly complex in terms of if groups have conflicting permissions. All you have to do is check if one group you're in has permission to do what you want to do, and if it does, allow the action. No need to make it more complicated then that.

And there's a mod for it

http://punbb.org/forums/viewtopic.php?id=6731

Rickard wrote:

IMPORTANT: Two rather annoying bugs have surfaced since the release of 1.2.5. See this post for instructions on how to fix them.

7,215

(18 replies, posted in PunBB 1.2 troubleshooting)

Rickard said you could skip the style check. And I assume on the page when you call that file, you also call common.php elsewhere wink

7,216

(4 replies, posted in PunBB 1.2 bug reports)

OK: I thought it allowed you to show all the pages in viewforum.php for that specifc forum on the bottom

7,217

(5 replies, posted in Feature requests)

Yeah
That and the ability to give moderator on a per group basis wink

7,218

(4 replies, posted in PunBB 1.2 bug reports)

In the paginate function, $cur_page can never be -1 wink

There are a few bugs that have, I think he put it, "piled up" since 1.2.5 was released (in addition to the 2 changes that you have to make) wink
So there should be another release at some point: as to when, it depends on if more things (which are more critical) show up.

7,220

(3 replies, posted in PunBB 1.2 troubleshooting)

Well, if this is PunBB 1.2, I think EFAM wasn't made for that
In any case, PunBB's 1.2 group system should take care of it

My Google search tells me that's "Lost connection to MySQL server during query."
As for what to do to fix it... I dunno tongue

7,222

(67 replies, posted in News)

It exists there only (and anywhere people download it) wink

ah. I thought you wanted both tongue

7,224

(4 replies, posted in PunBB 1.2 bug reports)

I was looking around the code, and I found this in the paginate function

    // If $cur_page == -1, we link to all pages (used in viewforum.php)
    if ($cur_page == -1)
    {
        $cur_page = 1;
        $link_to_all = true;
    }

Curious, I tried it. It didn't work. I checked the code in viewforum.php and found the problem:

$p = (!isset($_GET['p']) || $_GET['p'] <= 1 || $_GET['p'] > $num_pages) ? 1 : $_GET['p'];
$start_from = $pun_user['disp_topics'] * ($p - 1);

Basically, if you ever set p to lower than 1, it's set to 1 before paginate is called. However, fixing it isn't so easy, since allowing -1 causes a negative LIMIT, which spits out an SQL error wink

Not without modding the code, but I don't know the extent to which you'd have to change the code