1,301

(3 replies, posted in PunBB 1.2 show off)

Sweet smile

index.php?

eh, what? No offense, but this post sounds to me like you just heard someone talk about SEO and are trying to show off. wink

1. I've never seen any PunBB forum have trouble getting indexed (and indexed well).
2. Search engine optimization is not just about your URLs: in fact, they're not even a major piece
3. Search engine optimization does not mean adding .htm or .html to the end of your URL

As Bekko said, 1.3 will natively support SEF (search engine friendly) URLs. That simply means that PunBB will support URLs that aren't simply filename.php?querystring=something. Not all that important, in my opinion wink

As Matt said, content is king. You can certainly have a site that for various reasons is hard for search engines to index. PunBB is not such a site.

Mmm, then you probably need to add a new column to forum_perms (show_on_index) and change admin_forums.php so that the permission is used properly. Then, when all your forums are set up properly, you can change the index query to use your new column instead of the read_forum column.

If you're talking about a PunBB vulnerability, send me an email (smartys at this domain).

1,306

(9 replies, posted in Feature requests)

MattF wrote:
intedinmamma wrote:

Wouldn't $prefix="prefix" be better, so it's possible to set a prefix (or none) instead of the default one? Just a thought. smile

That's how it's done now, and I personally can't see how setting $prefix empty in any external scripts, (or to whatever prefix required), is any different to having a toggle within the query itself. I'd agree with you, personally. big_smile

You guys obviously haven't looked at the query builder code wink
Here's some example code:

$sql = 'SELECT '.$query['SELECT'].' FROM '.$this->prefix.$query['FROM'];

Now, how exactly is an extension writer supposed to change the prefix? Your way makes sense (although it's an ugly hack) if you're writing a query with all tables without the prefix. But what if you're just adding one individual table without a prefix to an existing query?

1,307

(3 replies, posted in General discussion)

Moved to General Discussion, since this has nothing to do with PunBB plugins.

1,308

(9 replies, posted in Feature requests)

Good point, we'll check it out

nuuskamuikkunen wrote:

Not sure if this will work (have no "orphaned" posts in my db)...

To find posts where users don't exist:

SELECT p.id
FROM posts p
LEFT JOIN users u
ON p.poster_id = u.id
WHERE u.id IS NULL

Then set poster_id for these rows to some new user id, etc etc?

From an older topic

1,310

(1 replies, posted in Programming)

http://punbb.org/docs/dev.html#integration
Then it's just a matter of looking at index.php to see what the queries look like

That's not what the article says: it says that the German official in charge of preparing a report on search engine privacy policies and how they comply with EU privacy laws feels that IP addresses should be regarded as personal data (which would change the way it's dealt with in privacy policies). That's one official's personal statement in an official venue. I don't see what's so special about that, given that his statement (as far as I can tell) has no impact other than that which the news coverage gives it. He could certainly put that in his report, which would give it more weight, but a report isn't law by any means. Just because he says he thinks IP addresses should be considered personal data when used to identify people does not mean that there will be new draconian laws implemented to prevent the harvesting of IP addresses.
Let me know if I'm missing something. smile

1,312

(6 replies, posted in General discussion)

$trunc_len isn't set anywhere in that code. It also has nothing to do with the actual size of the string, which is what you want in the if statement. You're looking for the strlen function.

That hook was not there at the time I wrote the post, it was added in the past 24 hours. There is also no guarantee that we won't decide to change the name of that hook between now and the beta. Finally, it doesn't change the fact that there are not yet any hooks within the admin pages themselves where you could add inputs for new config values easily. wink

1,314

(6 replies, posted in General discussion)

I'm running PunBB-Hosting off of a server from ThePlanet, excellent service smile

1,315

(51 replies, posted in PunBB 1.2 discussion)

Rickard wrote:
Smartys wrote:

Except when you tell a user that their code using mysql_* functions needs to start using MySQLi functions.

Yeah, but that's only if you need to use any of the added features. The mysql extension works with later version of MySQL as well.

Except that the default password handling was changed, which would lead to those "Client does not support authentication protocol requested by server; consider upgrading MySQL client." messages

1,316

(51 replies, posted in PunBB 1.2 discussion)

Rickard wrote:
Jérémie wrote:
Rickard wrote:

Weird that they're running completely different MySQL versions on different servers big_smile

A lot are. Especially since MySQL changed its password() field handling (at 4.1, I think) and it was a support nightmare from what I hear.

That was only a problem if you had a different version of the client libraries. This isn't an issue for a hosting company because when they update MySQL, they just recompile PHP at the same time.

Except when you tell a user that their code using mysql_* functions needs to start using MySQLi functions.

1,317

(1 replies, posted in PunBB 1.2 discussion)

Yup, we're aware of the problem and doing our best to resolve it smile

1,318

(51 replies, posted in PunBB 1.2 discussion)

Rickard wrote:
Hob Bramble wrote:

midPhase - http://midphase.com

I probably ought to get on them about upgrading that...

Apparently, you can just ask and they'll move you to a server with MySQL 5. Weird that they're running completely different MySQL versions on different servers big_smile

Probably to make it easier for people. The same reason a lot of hosts run both PHP 4 and PHP 5.

http://www.punres.org/viewtopic.php?id=229

Yes, except that first line is completely not required. And you could do it with appending instead, which is what I was talking about. But your way should work fine.

You simply append

 <a href="javascript:void(0)" onClick="document.getElementById(\'show_quick\').style.display = \'none\' ? \'block\' : \'none\'; insert_text(\'[b][color=red]@'.pun_htmlspecialchars($cur_post['username']).'[/color][/b] - \',\'\');" rel="nofollow" title="'.$lang_topic['Address Post'].'"><img style="vertical-align: middle;" src="'.$pun_config['o_base_url'].'/img/address_to.gif" alt="'.$lang_topic['Address To'].'" title="'.$lang_topic['Address To'].'" /></a>

to the original value of $username only when they're not the same user.

Look at the top of the file

Moved to Modifications, since that's what you're looking for wink
You can remove the width/height attributes in include/parser.php

Aha. Yes, the redirect function will only redirect to paths within the forum base URL.

AracornRed: Removing those lines will expose you to a security risk.
lostcoin: We would need to see your code to figure out what's happening wink