Search options (Page 1 of 2)

In the PunBB source there are code lines that wrap maybe 5 times on my display and that makes it very difficult to apply line-based patches to the source code since there will almost always be a conflict if I have made the slightest modification, even if the previous changes actually are compatible with the patch I'm trying to apply. It is also very difficult to spot exactly what the differences are when I run diff -u on the vanilla tree against my tree, to see what changes I have introduced. Furthermore it is quite difficult read lines of that length, for example SQL queries that are logically split up into several lines are always much easier to read, and it follows that it also is much easier to edit lines that are split up, since you more easily comprehend what's going on.

I'm sure that you have strong feelings for your current coding style, but combined with the fact that the patches and modifications to PunBB are line-based it makes the current situation very unsatisfying. Is there any chance that the coding style may be reconsidered for 1.3? If not, I think you should to consider some better way of distributing patches for PunBB, that does not as easily introduce conflicts when applied.

I have noticed that some users can get logged in twice. This causes messages from that particular user to be displayed twice.

I think the problem may be that you we do a query to get online status, check the online status and then update the database. This would cause a race condition if it isn't done atomically. Hm.. is this the case or would the begin/commit enclosing prevent that?

I am using postgresql and latest punbb.

EDIT: Hm.. after some more checking it seems like the transactions really should prevent race conditions, but I can't see how a users could get inserted twice into the online table otherwise..

If you view the profile for another user it displays the language for the current user.

Possible fix: at line 1150 change

                                if ($pun_user['language'] == $temp)

to

                                if ($user['language'] == $temp)

and insert u.language into

$result = $db->query('SELECT u.username, u.email, u.title, u.realname, u.url, u.jabber, u.icq, u.msn, u.aim, u.yahoo, u.location, u.use_avatar, u.signature, u.disp_topics, u.disp_posts, u.email_setting, u.save_pass, u.notify_with_post, u.show_smilies, u.show_img, u.show_img_sig, u.show_avatars, u.show_sig, u.timezone, u.style, u.num_posts, u.last_post, u.registered, u.registration_ip, u.admin_note, g.g_id, g.g_user_title FROM '.$db->prefix.'users AS u LEFT JOIN '.$db->prefix.'groups AS g ON g.g_id=u.group_id WHERE u.id='.$id) or error('Unable to fetch user info', __FILE__, __LINE__, $db->error());

I have disabled user info in the posts on my forum since they make the forum view somewhat less bloated. However when a guest posts I'd like to see the e-mail address that the guest has filled in, but it doesn't seem to be possible. So I propose a change:

$username = pun_htmlspecialchars($cur_post['username']);

to

                if ($pun_config['o_show_user_info'] != '1' && $cur_post['poster_email'] != '' && !$pun_user['is_guest'])
                        $username = '<a href="mailto:'.$cur_post['poster_email'].'">'.pun_htmlspecialchars($cur_post['username']).'</a>';
                else
                        $username = pun_htmlspecialchars($cur_post['username']);

in viewtopic.php at line 258.

Our page:

http://enhjulingsfolket.se/

I have designed a custom front page and the forum index has been eliminated, with some PHP hacks.

The page currently looks awful in IE, suggestions would be appreciated. Maybe I could try using IE7 from http://dean.edwards.name/IE7/ and see if that works better.. Has anyone used this with PunBB? In particular i use full aplha PNG, max-width and width. Maybe there is something else that IE misses, the logo also had the wrong size in IE when I checked. Try making the page smaller, and the columns will end up on top of each other.

Logging in did not work in IE6 when I tried it either, any ideas why? Maybe I could enable P3P. I'm not using any funny domain redirection or anything, enhjulingsfolket.se is an A record pointing at the server.

It feels like waste of time to support a broken browser...