2,701

(39 replies, posted in General discussion)

Don't forget to look at the extensions. The web developer extension is great; it allows you to highlight table and box level elements and will even show you labels with the classes used. Great for finding out where you went wrong or how a page is constructed.

There is an error on that page but I don't think thats quite it. From what I can see class="punhead" needs to be added to the <td>tag at line 189 and removed from the <td> tag at line 192.

Rickard. If you want to see what the problem is, trying setting a background colour for punhead and see what happens on the viewtopic page. The reason I need it changed is I am trying to replace cellspacing="1" with borders set through the stylesheet. As it is at the moment punhead has been set on the inner nested table rather than the outer table which screws everything up.

2,703

(18 replies, posted in Feature requests)

I would have thought that a post vetting/approval system which has been requested particularly by people wanting to use PunBB in a business invironment would be higher up the list of priorities. Particularly as such a system eliminates spam problems and also some of the problems that would be addressed by a kill list.

2,704

(18 replies, posted in Feature requests)

First, if you have killed somebody's posts but you can still see the replies to those posts won't if get a little confusing.

Second, if somebody replies quoting the post you have killed do you still see the quote or does the quote get killed as well.

Third, if you have a long list of killed posters won't the resulting db query get rather long and, consequently, slow.

Not saying it's not a good idea but it does need some thinking about.

2,705

(6 replies, posted in PunBB 1.2 discussion)

Dale wrote:

I wouldnt mind having a vbulletin style templating system. All the styles are stored in a big file (599kb) in the admin directory and then its all accessed in that. It would be so kewl if PunBB had that feature.

This has already come up a few times. The answer was no, no way, no how, never.

2,706

(8 replies, posted in PunBB 1.2 troubleshooting)

Silly me. I think this is the good old IE width bug rearing its ugly head again. Now for the difficult bit i.e tracking it down.

2,707

(8 replies, posted in PunBB 1.2 troubleshooting)

Frank, I dont get it. It's his index and viewforum pages which are screwed in IE and they don't have any input/texarea fields. The pages with input fields are actually displaying correctly in IE though the opposite is happening in Firefox.

2,708

(8 replies, posted in PunBB 1.2 troubleshooting)

Frank, he has the opposite problem i.e. the forum is not shrinking at all so it is causing a horizontal scrollbar. There is probably an unwanted fixed width in there somewhere. I will have a look at the source and stylesheet and see if I can find it.

EDIT
There are more problems than you think. The forum actually works perfectly in Firefox/Mozilla but your contact page is broken.

2,709

(2 replies, posted in PunBB 1.2 discussion)

I am probably going to repeat earlier remarks but what the hell.

1. Give the part of the header which contains the board title its own class e.g. .punlogo. The reason is to make it easier for site integration. Users could insert a background graphic or their site logo via the stylesheet without having to edit main.tpl. Even without a graphic somebody might want to make the board header a different colour from the rest of the board. The default setting would be the same as at present ie same as .punhead.

2. .punspacer is overused. Reserve it for empty spacing and use a new class .punfilledspace for whitespace which contains text/links. cellspacing and cellpadding on empty white space elements should be set to 0. That way the height of empty spacing could be set exactly (even to nothing) as there would be nothing to restrict the height adjustment.

3. Not strictly CSS, but related. Put the admin interface on it's own template e.g. admin.tpl which will in fact be a copy of the standard main.tpl and have it use one of the default styles. The reason is it is easier to integrate the board into a site if you don't have to worry about admin. It also speeds up the admin interface since it is using the standard template rather than having to sit in the middle of some three column portalized thingy. It takes one variable at the top of common.php and common_admin.php and a couple of if{}  statements to do this. I don't think this change could be considered a move towards templating, it's just separating the two distinct interfaces of the board. If people want to re-integrate the admin interface is just a matter of setting the value of the variable at the top of common_admin.php. Mind you, this is so simple to do I could always write some instructions as a mini mod.

4. There is some duplication of classes. At the moment you have puncon1 and puncon1right where the only difference is alignment. You also have punright. You should be able to double up classes e.g. <td class = "puncon1 punright">. Same goes to top and center alignments. that should enable you to get rid of three or four classes altogether. As far as I know this works in all modern browsers but better ask Louis about that as there may be some problems I don't know about.

5. Put main navigation in a <div> and give it an id of #punnavbar. Wanting to style main navigation differently from the rest of the board is a fairly common thing and this would make it easier.

2,710

(16 replies, posted in Feature requests)

0zone wrote:

Thats all ok, excluding the css part.

CSS can style things, but it can't put things together. Its only capable of so much. You don't see designers using the same code over and over to get differant looking websites do you? No.

Yes you do.
http://www.csszengarden.com/
Same markup, dozens (or more) different sites.

2,711

(1 replies, posted in Programming)

Just came accross this.
http://www.phpinsider.com/php/code/SafeSQL/

Does anybody have any experience of using it. Generally, is it something that might be a good idea particularly for those of us not particularly clued in when it comes to mysql.

2,712

(16 replies, posted in Feature requests)

Face it. Your only hope is that somebody else will feel the same as you do and come up with an alternative release of PunBB which includes templates.

2,713

(4 replies, posted in Programming)

That would explain the obsession amongst coders for reducing the number of queries used.

One thing I forgot to ask is what is worse for performance; a large include file where only some of the code is actually needed or several small includes where all the code in each file is actually used. In other  words, is the most crucial factor the size of the included file or the number of includes used.

2,714

(4 replies, posted in Programming)

I am curious about what causes most performance overhead/drag in a script

1. Database queries
2. Templating
3. Includes
4. etc.

For example, very often something that could be done via templating could also be done via file includes instead. Which is going to cause the biggest performance hit.

2,715

(16 replies, posted in Feature requests)

If you are going to do a completely customized design then even if PunBB used templates you would still have to customize them. There is no difference between customizing the markup in the php files and customizing markup in templates until of course there is an upgrade.

2,716

(4 replies, posted in PunBB 1.2 troubleshooting)

MarcB wrote:

Ahhh if all the tables have the same class, why not simply redefine .punmain's value? Just curious, haven't checked the code.

How would you do that? I can't see anyway of doing it in the style sheet that works in IE without having to take out all the cellspacing from the php files anyway. Even then it wouldn't work in Safari.

2,717

(1 replies, posted in Programming)

The second doctype puts the browsers into standards compliance mode. The first puts the browers into quirks (backwards compatability) mode. You should be using the second one.

2,718

(4 replies, posted in PunBB 1.2 troubleshooting)

Go through the php files and find all tables with a class of .punmain and change their cellspacing value to 0. Doing this will also remove the outside borders. If you want to restore the outside border then simply set a 1px border on .punmain in the stylesheet.

2,719

(4 replies, posted in PunBB 1.2 troubleshooting)

The main navigation links are generated by a function called generate_navlinks which is in the functions.php file. I think it starts on line 175.

zc923 wrote:

Well, the program that I have will only work in Windows 98 se.

Wait a minute!
*ding* the light bulb is on.

What if I install the win xp driver for the card off of the win xp cd?

Installing an XP driver on a Win98 system is not a good idea.

I did see a post somewhere regarding this card and a similar problem with XP. It seems the solution was to reinstall XP after which the card worked perfectly. Why that should work I have no idea.

2,722

(35 replies, posted in PunBB 1.2 show off)

Paul Marsland wrote:

Actually the code on the Mod Discussions forum does not work, it refers you to the forum homepage.

That was one of the problems I was having which is what prompted me to ask you for your code in the first place. I am putting together a front page something like PunBB's main page but incorporating your login which I will put up as a demo.

2,723

(4 replies, posted in PunBB 1.2 troubleshooting)

If you want to put a banner at the top of the page then you add it to the file main.tpl which is the template for all PunBB pages. Do you really just want to add something to the top of the login page. If so thats rather more complicated.

2,724

(4 replies, posted in PunBB 1.2 troubleshooting)

Can you give a few more details about exactly what result you are trying to achieve.

2,725

(19 replies, posted in General discussion)

Just picked this up from Digital Media Minute
http://www.digitalmediaminute.com/archives/000498.html

It seems there were 73,000 downloads of Firefox on the day it was released plus 30,000 failed downloads. Half the downloaders were identified as being IE users.