there'll be an extension that allows you to edit hooks in place without reinstalling the extension all the time.
Nice, that will be almost a required extension for developers of extensions!
You are not logged in. Please login or register.
PunBB Forums → Posts by Rich Pedley
there'll be an extension that allows you to edit hooks in place without reinstalling the extension all the time.
Nice, that will be almost a required extension for developers of extensions!
Rickard wrote:My main issue with apostrophes and quotes is that if we use the "fancy" versions in the language packs, we need to make sure that they're also used in posts.
I don't see why... you use ellipsis in the lang pack, yet everyone use three-dots inside posts. Same as non-breaking space.
It's not a big deal, in my opinion.
A lot of people get it wrong all the time.
... is not the same as an ellipsis … if memory serves. The first is actually - full stop, full stop, full stop (or period period period).
:grin: me too! But one the reasons I mentioned it was because I was checking accessibility at the time, but for some reason decided to post it here instead.
I think it may be confusing to some people that there is nothing except, for example:
You must enter a name for the category
(oh and no full stop btw)
Descriptive, may be, but for accessibility a tiny wee bit extra might help. So think about adding 'error' to the title of the page, adding an in document link to go straight to that message, or extra text like 'use your browser back button and try again'
mind you the 'forum message' could perhaps be changed to 'forum error message'?
thank you.
I'd argue the use of U+279C or ?
when typing always read back what actually appears that should have been:
I'd argue against the use of
oops.
and that is about it for an initial check - I'll need to do some further testing once I have access to a site with 'data' - I was testing on the initial install.
I have to say though congrats to all involved - didn't find any major issues (I'm not an expert). Others may find issues I haven't.
example for the admin side:
adding new category:
putting in a position of 'w' doesn't produce an error - shouldn't it at least be mentioned? (I assume it is checking things correctly as it then came back with a position of 0.
Also could this 'info' page also feature a link back to the page from whence you came?
Admin -Settings - setup - default timezone
vs front end registration(and profile) - Your timezone:
don't match - front end goes to +14 back end only to +13!!
Onto the admin
same comment about links (underline when active etc)
Skip link - 'skip to forum content' this is fine on the public side, but is the wording OK for the admin pages?
<div class="main-head">
<h1><span>{ Information }</span></h1>
</div>
appears *after* the navigation menu - meaning you have to got through those links before you find out what page you are on (well if the page title is ignored). I realise it may not be possible to move this, so just a comment about it.
Settings - Features
1. General features (go to censoring to setup censored words list)
surely the bracketed text would be better served if it was next to the censor words selection?
[edit : snip posted elsewhere]
Extensions (I hope I didn't miss this elsewhere)
When installing a lot of the text appears within the <form> even though there is no actual need for it. It might be better to have the text display before the form.
On a separate note, that extension section is going to get very big very fast for some of us - could the details shown be reduced to bare minimum, with a 'more details' link?
damn blast and ******:
accesskey="s" title="Accesskey: s" on the send an email form - is that all over the place? It would be preferable if there were either NO accesskeys set, or they were settable by the user. I can cite references on this subject(Wats.ca), and provide you with a few links to pre written accesskey scripts (my coding is not the best in the world, but I do have one...)
quick grep finds occurances in:
edit.php(344)
edit.php(345)
misc.php(256)
misc.php(398)
post.php(539)
post.php(540)
search.php(1234)
userlist.php(192)
viewtopic.php(578)
viewtopic.php(579)
lang\English\common.php(25)
lang\English\common.php(27)
Jérémie wrote:elbekko wrote:I'd actually prefer something like this for the arrow:
U+279C ? Heavy round-tipped rightward arrow
If UTF-8 is in anyway, why not use it?
Is it included in most (really MOST) default font used by OS&UA?
http://jrm.cc/extras/rarr.html ? works pretty well too. Seems to have the right coverage.
I'd argue the use of U+279C or ? - but it does depend on what browsers are being supported, and whether tables are involved... I'd have to search my email logs but this was tested ad infinitum a few years ago by another group I am on - the conclusion was that it wasn't cross browser friendly. Though we were testing in a myriad of weird and wondeful browsers I think it may have been a flavour of IE and Konqueror that had issues with it.
LOL Paul re the captions. We've had problems with IE and all things so I wouldn't be surprised if it wasn't IE6. If the table immediately follows a <h2> then replicating the info in the caption would be pointless. But if there is anything in between, or even the possibility of anything in between then I think they would become more relevant.
With the plugin and extendable possibilities opening up, erring on the side of caution and adding them may be best
you've lost me on that one - which page is that on? (if it is this one I apologise in advance)
Ok found another thing while looking for a decent accessible table article.
Tables should have <caption> as well.
Accessible Data Tables which is hefty reading but does fetaure a bit about scope against id and headers.
Screen reader support for scope however was patchy.
hidden skip link works for me, and is ideal for this situation.
last post link, works for me. well thought of!
Rich. First of all thanks for taking the time.
no problem.
As regards divitis.
I should have realised! It doesn't worry me as such, and certainly doesn't affect accessibility anway.
Quick post form.
arggh my bad I missed the fact the label went around it all.
Tables. I will do some research regarding id's. I'm sure when I showed somebody a versio with id's they said it was overkill for a simple table but I will look into it further.
It is a simple table, and I'd have to ask around for the definitive on it. Overkill, well adding accessibility specific markup on tables is always seen that way anyway - scope ought to be enough I'm just not sure it is
Last post link. I can't come up with a solution either. Just putting in an id or something as hidden text is just a hack to satsify the checkpoints and would actually make things worse.
Hidden text isn't the answer - my other half has occasionally had to keyboard navigate, and utilise Dragon naturally speaking which is where the issue of unique visible link text is perhaps more necessary.
One to ponder over in the coming months.
Links. I will look into it.
Thanks.
Profile avatar. Its required because it needs a value before submitting the form otherwise you are submitting a form which does nothing. My favoured solution would be to remove the required indicator and then change the error text which appears if you submit the form to "You must select a file to upload before submitting this form". That traps the mistake without misleading people. I could also add help text under the field which is part of the label which says the same thing.
I think it would be better, lets face it it made me wonder why, so I'm sure others will as well.
search results. That was actually on my list.
great minds...
As with all I post it can only be suggestions, some will be good, some will be bad.
leaving the password input unencrypted might also encourage cut'n'paste. I'd personally rather is was treated as a standard password.
I'd thought of that, the same could be said of the signature form which doesn't have required on it.
Some of this is not directly related to accessibility but found during testing - if it isn't suitable here let me know and I'll repost other bits elsewhere.
This is just a quick front end test, I'll work on the back end another time.
All tested with the default theme.
divitis, some of these should be <p> not <div> eg.
<div id="pun-title">
<div><strong>beta beta</strong></div>
</div>
<div id="pun-desc">
<div>punbb access</div>
</div>
the inner div's could easily be a <p>
I realise that as many hooks have to be put in as possible, but if the number of div's can be cut down it may help. (yes I know it is probably themeable)
The skip link, even works in IE7 (haven't tried in earlier versions)
In table markup I see use of: scope="col" this isn't as good as utilising headers and ids, more difficult to code, but may be more suitable.
Default last post link text - eg.Today 10:59:23 it doesn't really describe what it is linking to (but you can easily argue 'it should be bloddy obvious on a forum') however there may be some times when the link text is not unique, and therefore you might get 2 links pointing to different places but with the same dats and time - which would make this unsuitable. Sorry I haven't got a suggestion at this time to fix it.
Suggestion re links - if underlined remove underline on hover(and active etc), if not underlined, add underline on hover(and active etc). This does happen in some places, but not all. eg breadcrumb
Quick post form,
<em class="req-text">(Required)</em> if that text isn't in the <label> then screenreaders who have gone into forms mode won't be able to 'hear' it. However I do notice the workaround on post.php, but it wasn't implemented here.
Profile section : avatar
sounds like a silly question but why is it 'required' when surely it is optional?
search result - suggestion, add an id(#searchresults) and send the user straight to the results, rather than forcing someone to tab through (or even scroll down).
If anything needs explaining further or expanding on, feel free to ask and I'll do my best to answer them.
I'll install locally and see what I can do - especially as I did offer!
MySQL client version: 5.0.22
MySQL client version: 4.1.22 (applies to more than one installation)
MySQL 4.1.9-max (via easyphp 1.8)
unless you have written some specific sqlite queries it should just be a matter of transferring the data from the sqlite database to the mysql one.
Why simply don't add, in the registration page, a question (choosed by the administrator in acp) that only a human can answer?
Dunno, something like "What's the color of the lemon?" and stuff like that
Accessibility reasons for one, though personally I hate that technique because some of the questions people have come up with aren't as obvious as they should have been. (for instance the lemon question - a blind user might not know the answer...)
got it!
exporting from sqlite had changed all NULL to ' '
so I've re-uploaded all affected tables and it appears to be working.
I thought of that, but everything seems ok - I'll re check against the sql file and see if I can spot any errors.
Debug info from viewforum:
Time (s) Query
0.00064 SELECT u.*, g.*, o.logged, o.idle FROM users AS u INNER JOIN groups AS g ON u.group_id=g.g_id LEFT JOIN online AS o ON o.user_id=u.id WHERE u.id=1987
0.00017 UPDATE online SET logged=1182769455 WHERE user_id=1987
0.00029 SELECT * FROM online WHERE logged<1182769155
0.00028 SELECT f.forum_name, f.redirect_url, f.moderators, f.num_topics, f.sort_by, fp.post_topics FROM forums AS f LEFT JOIN forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id=1) WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND f.id=19
0.00021 SELECT COUNT(id) FROM reports WHERE zapped IS NULL
0.00012 SELECT COUNT(a.id) AS LAST_ID FROM akismet AS a where a.poster!=""
0.00071 SELECT id, poster, subject, posted, last_post, last_post_id, last_poster, num_views, num_replies, closed, sticky, moved_to FROM topics WHERE forum_id=19 ORDER BY sticky DESC, last_post DESC LIMIT 0, 30
0.00058 SELECT search_for, replace_with FROM censoring
Total query time: 0.003 s
debug from viewtopic:
Time (s) Query
0.00063 SELECT u.*, g.*, o.logged, o.idle FROM users AS u INNER JOIN groups AS g ON u.group_id=g.g_id LEFT JOIN online AS o ON o.user_id=u.id WHERE u.id=1987
0.00017 UPDATE online SET logged=1182769496 WHERE user_id=1987
0.00030 SELECT * FROM online WHERE logged<1182769196
0.00039 SELECT t.subject, t.closed, t.num_replies, t.sticky, f.id AS forum_id, f.forum_name, f.moderators, fp.post_replies, s.user_id AS is_subscribed FROM topics AS t INNER JOIN forums AS f ON f.id=t.forum_id LEFT JOIN subscriptions AS s ON (t.id=s.topic_id AND s.user_id=1987) LEFT JOIN forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id=1) WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND t.id=3589 AND t.moved_to IS NULL
0.00022 SELECT COUNT(id) FROM reports WHERE zapped IS NULL
0.00013 SELECT COUNT(a.id) AS LAST_ID FROM akismet AS a where a.poster!=""
Total query time: 0.00184 s
PunBB Forums → Posts by Rich Pedley
Powered by PunBB, supported by Informer Technologies, Inc.