well, it still doesn't work for "show recent topics". just uploaded a fixed version again...

Just had an idea:
How about an option to sort the post by deleting date? Seems kinda more logical.
I wanted to add this option first, but I deleted it again, because I did the checking for the post being deleteable or not differently from now. But since I do it with a query now, it should be possible...

just uploaded the new version to PunRes. Should work now.

in admin/extensions.php around line 90 (foreach-loop):

if ($cur_note['attributes']['type'] == 'uninstall' && trim($cur_note['content']) != '') 
                 $uninstall_note = '\''.$db->escape(trim($cur_note['content'])).'\'';

Change this to the following, so that it displays more than one note:

if ($cur_note['attributes']['type'] == 'uninstall' && trim($cur_note['content']) != '') 
                 $uninstall_note .= '\''.$db->escape(trim($cur_note['content'])).'\'';

well of course there is a query executed when searching for unanswered topics...
will upload the new package in a few minutes

Uhmmm... Will check that tonight. I probably just used p instead of t. Could you post the query please?

182

(99 replies, posted in PunBB 1.3 additions)

Yes I will want help. As soon as Rickard tells us to start, we might want to split that stuff...

yes, and when you register also. so basicly they can check it then...

Isn't there a checkbox that says "Remember me".
Wouldn't it be enought to just uncheck that?

just logout
usually the userdata is reset in internet cafes and other public places anyways ...

thx

fixed the Deleted Posts Log
There was a tiny bug when you were using a db prefix.

Deleted Posts Log for 1.3
http://www.punres.org/desc.php?pid=389
-contains an extra page for the admin section


Subscribe User for 1.3
http://www.punres.org/desc.php?pid=391

189

(2 replies, posted in PunBB 1.3 troubleshooting)

ok ok.

In the query list at the bottom of the page, I think you got an s for seconds where there doesn't need to be one (I think it was in the total time column).
Also, if that column could have another background, that would be nice...
Sorry I don't have it here right now...

191

(2 replies, posted in PunBB 1.3 troubleshooting)

I don't know but...
Wouldn't it be better to redirect to the page you came from when deleting a post. It is kind of annoying in large topics... (it always redirects to the first page of the topic).

192

(2 replies, posted in PunBB 1.3 troubleshooting)

cool. thx

193

(2 replies, posted in PunBB 1.3 troubleshooting)

There are a few queries e.g in moderate.php, that do something like this:

'SELECT 1 FROM topics WHERE id IN ('.implode(',', $topics).')'

And then you compare the num_rows of the result to the count of the array $topics.

I don't know if this is really optimization, so - would it be faster to do a query like this?

'SELECT COUNT(id) FROM topics WHERE id IN ('.implode(',', $topics).')'

Thanks

194

(3 replies, posted in PunBB 1.3 extensions)

When you add an uninstall note to an extension, it does not display them as nicely as it does for the install notes.

Please add class="note" to the h4, and also add the numbering in the paragraph.

Thanks wink

195

(99 replies, posted in PunBB 1.3 additions)

When is the language system ready for translation?

196

(1 replies, posted in PunBB 1.3 troubleshooting)

The bbcode does not seem to work properly...
At least the bold text...
look here

197

(2 replies, posted in PunBB 1.3 troubleshooting)

Just do the same testing you do for the user (if it is deleted or not...)
The following would solve it:

The query should look like this:

$query = array(
         'SELECT'    => 'r.id, r.post_id, r.topic_id, r.forum_id, r.reported_by, r.created, r.message, t.subject, f.forum_name, u.username AS reporter, p.id AS post_exists',
         'FROM'        => 'reports AS r',
         'JOINS'        => array(
             array(
                 'LEFT JOIN'        => 'topics AS t',
                 'ON'            => 'r.topic_id=t.id'
             ),
             array(
                 'LEFT JOIN'        => 'forums AS f',
                 'ON'            => 'r.forum_id=f.id'
             ),
             array(
                 'LEFT JOIN'        => 'users AS u',
                 'ON'            => 'r.reported_by=u.id'
             ),
                array(
                    'LEFT JOIN'        => 'posts AS p',
                    'ON'            => 'r.post_id=p.id'
                )
         ),
         'WHERE'        => 'r.zapped IS NULL',
         'ORDER BY'    => 'r.created DESC'
     );

And then, modify this variable in the loop:

$post_id = ($cur_report['post_exists'] != '') ? '<a href="'.pun_link($pun_url['post'], $cur_report['post_id']).'">Post #'.$cur_report['post_id'].'</a>' : $lang_admin['Deleted post'];

This way it should work.

198

(3 replies, posted in PunBB 1.3 troubleshooting)

Maybe you could also change the bullets, and make it look like the rep-item databoxes in the admin section...
Just an idea wink

199

(2 replies, posted in PunBB 1.3 troubleshooting)

The maintenance help message - it says "...to be be...". You can find it here: lang/English/admin.php (line 398)

200

(8 replies, posted in PunBB 1.3 troubleshooting)

lie2815 wrote:

By the way, where can I download the latest revision (as a complete package)? I just don't find a link for something like that. Is the link in the post by Rickard up to date?

Never mind, found it...