• From: Russia
  • Registered: 2008-07-22
  • Posts: 713

Topic: Bug in the extension system

A bug in the extension system was found. I suggested a fix. I would like to ask extension developers for help in testing. Please, download the last revision of PunBB from SVN and test if your extensions work correctly. Thank you.

PunBB team intentions, personal tasks.

Parpalak's Website

2 Reply by dimkalinux (edited by dimkalinux 2009-12-25 09:57)

  • From: Ukraine
  • Registered: 2008-10-31
  • Posts: 762

Re: Bug in the extension system

Maybe more correctly use global instead $GLOBALS? Just style as defined other globals var in forum code.

  • From: Russia
  • Registered: 2008-07-22
  • Posts: 713

Re: Bug in the extension system

1. If we use 'global' every hook code will contain 'global $ext_info_stack;'. I think several global definitions in a scope isn't so pretty.

2. One of the developers has already used $GLOBALS['base_url'] in that piece of code.

3. cache_hooks.php contains an auxiliary code generated by the forum script. It's not a problem if this code violates PunBB code style convention.

4. According tests $GLOBALS is a little bit faster.

That's why I've chosen $GLOBALS.

PunBB team intentions, personal tasks.

Parpalak's Website