Erm, actually, that doesn't matter: if whenever it's displayed Rickard calls punhtmlspecialchars there's no XSS.
The preg_replace I was referring to was the original one, with the IP tongue

Oh cool, a missing punhtmlspecialchars tongue

Edit: It would be nice if these things were reported to Rickard (at least) in addition to being posted at these places
http://www.securitytracker.com/alerts/2 … 13446.html

Oh, and just to beat you guys on another "path disclosure"
http://site.com/forum/include/dblayer/common_db.php

I've tested it locally before and I came up with errors (a warning about $db_type not being set and one about error() not being an existing function). Not that serious as far as I know (the only thing I could think of is if you have register_globals on and aren't using p_connect with MySQL: I believe you could be able to max out connections to the MySQL server in that case)

7,304

(19 replies, posted in PunBB 1.2 troubleshooting)

Well, where-ever avatars are displayed tongue
So, when they're displayed (not uploaded) on profile.php
viewtopic.php as well

niggerilo wrote:

There is no SQl-inj, it's just a bug in preg_match() function

OK, then find the problem in the regular expression, it seems to work just fine to me

7,306

(19 replies, posted in PunBB 1.2 troubleshooting)

Manually change places that display from using $pun_config['o_avatars_dir']

It has: I reported it about a week ago wink

Oh, and it's more bothersome then anything else: while you could reset someone's pass like that, you can just use Forgot your Password to give yourself access back.

Damn, in fixing the SQL errors I mess up the already working code it seems tongue

Mmm, silly me, trying to make the posts array an intval smile
With crappy looking (and probably invalid) markup, it's ready for beta! Now to find someplace to upload it!

http://www21.brinkster.com/keyrex1/Spli … 1_beta.zip

Have fun (remember, it's a beta, so don't use it in a production environment and report all bugs to me)
Oh, and to download it, right click and choose Save Target as

7,309

(4 replies, posted in PunBB 1.2 bug reports)

Notice: Undefined index: move_to_forum in c:\apache\apache\imperial\public_html\forum\moderate.php on line 294

If there's no forum to move to

7,310

(19 replies, posted in PunBB 1.2 troubleshooting)

Mmm, good point :-/

7,311

(19 replies, posted in PunBB 1.2 troubleshooting)

Well, like this

forum A is installed in /home/apache/site/forum/
forun B is installed in /home/apache/site2/forum/

You want to use the avatar folder in forum2 for forum
You would use ../../site2/forum/img/avatars/ (I can't remember if you should use a trailing slash) for forum A

7,312

(19 replies, posted in PunBB 1.2 troubleshooting)

Try using ../ and such to make the path relative?

Yeah, exactly what I was thinking

I can't replicate that on my forum, I get a Bad Request page

Edit: and on another forum of mine I get 127.0.0.1 wink

Seems you missed this

    // Is get_host an IP address or a post ID?
    if (preg_match('/[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}/', $_GET['get_host']))
        $ip = $_GET['get_host'];

While I don't know regular expressions (actually, this one I understand: max of 3 digits, digits are 0-9, digits are seperated by .s), in debug mode it's telling me 2' is considered a post id (which due to the intval later on is changed to 2)



Edit again: However, I found something similar:
http://www.someplace.com/forum/moderate … .500.500.1
Warning: gethostbyaddr(): Address is not in a.b.c.d form in[place]\forum\moderate.php on line 53
Basically, just make up a number outside the range.
Not very serious other then the path disclosure tbh wink



Oh yes, and nice work removing the copyright on the forum:
http://forum.pch-team.com/index.php

Doesn't work for pre 1.2.x wink

7,316

(3 replies, posted in Programming)

You made a comment outside of the PHP tags wink
Your insert query structure is wrong
should be

insert into [table] ([column], [column]) values ([value], [value])

7,317

(2 replies, posted in PunBB 1.2 troubleshooting)

It worked before
Problem with adding the messages table, something about an SQL logic error or something else

Edit: error was SQL logic error or missing database in query or something like that

Edit2: It seems that's an error with SQLite

It's not a problem, it's an intentional feature decision by Rickard wink

7,319

(7 replies, posted in PunBB 1.2 discussion)

mmm, interesting

They removed the copyright sad

That actually took very little work to mod so as to work alright. Now I just have to fix a couple SQL errors that can be caused and change the layout over to 1.2.3 style (which I might have trouble with tongue)

So if someone can re-do the markup for me and save me the trouble, that would be super *hint hint* tongue

Mmm, I have 2 weeks off starting this Friday, so I'll see if I can get something working then smile

7,322

(4 replies, posted in Programming)

Unixtime
http://www.onlineconversion.com/unix_time.htm

7,323

(13 replies, posted in General discussion)

Izzle

I am pleazed ta announce tha releaze of PunBB 1.2.3. This releaze, similarly ta 1.2.2, has been made primarily ta address a numba of security vulnerabilizzles. Of these vulnerabilizzle one is ta be considered critical cuz I'm fresh out the pen. PunBB 1.2.3 is a recommended upgrade fo` everyone. If you is fo` some reason unable ta upgrade, you should at least makes sure ta apply changeset 123 fo' sheezy. In addition ta said security updates, a killa of minor bugfixes have also mizzy it into this releaze.

I'm sorry fo` tha ratha hizzle frequency of security updates these last few weeks. Hopefully there won't be a need fo` any more updates ta tha 1.2 tizzle fo` some time now. PunBB is currently undergo'n a security audit n this is tha reason fo` tha hizzle shot calla of security updates lately motha fucka.

I would like ta T-H-to-tha-izzank John Gumbel n Smartys fo` both report'n tha critical vulnerability (just a few hours apart), Jiznohn Gumbel fo` report'n tha e-mail heezeeer injection vuln so you betta run and grab yo glock. n Smartys fo` steppin' tha SQL injections in tha admin scripts . Ill slap tha taste out yo mouf. Thank you bizzay fo` giv'n me due time ta fix n releaze 1.2.3.
---
"Programming is like sex . Real niggas recognize the realness.: one mistakes n you have ta support it fo` tha rest of yo life."

7,324

(8 replies, posted in Programming)

Nibbler, you pwn: that's EXACTLY what I need big_smile

7,325

(8 replies, posted in Programming)

Mmm, looks good smile
So where can I get it? tongue