Search options (Page 3 of 54)

sounds like you've already made up your mind ...

Ok, it was a really easy bug, it just showed the first value (but in the htmlsource, all items were there) ... it was just a neglected  htmlspecialchars() on the output variable

Bugfix:

#
# OPEN ------------------------------------------------------
#

AP_Attachment_Mod.php

#
# FIND (line 597) -------------------------------------------
#

                                            <input type="text" name="file_ext" value="'.$attach_file_extarray[$key].'" size="80" />

#
# REPLACE WITH ----------------------------------------------
#

                                            <input type="text" name="file_ext" value="'.htmlspecialchars($attach_file_extarray[$key]).'" size="80" />

#
# SAVE, UPLOAD-----------------------------------------------
#

I'm leaning towards updating the download, including the fixes that has been made ... we will see how much time I have during the weekend

no, re-check the original readme.txt, and compare it to what you pasted as "#---------[ 43. FIND (line: 187) ]--------------------------------------------"

You'll see that those differ at the end ....

either way, it's the  false) or error   instead of   true) or error    that should be changed and the comment that needs to be added to that row ... then it should work ...

now I need to get back to work

well, I told about it in the installation guide, did you read the "Installing the mod on PunBB 1.2.6+"?
In there you find:

Edit: aaah, you're meaning the actual text in readme.txt is wrong... hmm... gotta take a look...

Well, if someone delete it ,it shouldn't be there IMHO, just like posts, threads, forums, categorys, users, groups etc.
(And if the post itself then looks odd, why not alter it at the time one delete the file, as you're already in edit mode?)

Anyhow, it sounds like fluff to me, so I won't add such a thing. But I guess there's always a possibility for a mod on the mod
(just like I don't add javascripts to handle the uploads and such)

sounds like you haven't done all the edits in viewtopic.php, recheck those steps. (it should be visible above the signature)

I would think the best place to create the thumbnail would in the attachment functions file, after it's moved to the correct location.

Look for this in attach_create_attachment()   (include/attach/attach_func.php ~line 106)

        if(!move_uploaded_file($tmp_name,$pun_config['attach_basefolder'].$pun_config['attach_subfolder'].'/'.$unique_name))
            error('Unable to move file from: '.$tmp_name.' to '.$pun_config['attach_basefolder'].$pun_config['attach_subfolder'].'/'.$unique_name.'',__FILE__,__LINE__);
            //return false;
            
        if(strlen($mime)==0)
            $mime = attach_create_mime(attach_find_extention($name));
        
        // update the database with this info
        $result = $db->query('INSERT INTO '.$db->prefix.'attach_2_files (owner,post_id,filename,extension,mime,location,size) VALUES (\''.$pun_user['id'].'\',\''.$post_id.'\',\''.$db->escape($name).'\',\''.attach_get_extension($name).'\',\''.$db->escape($mime).'\',\''.$db->escape($pun_config['attach_subfolder'].'/'.$unique_name).'\',\''.$size.'\')')or error('Unable to insert attachment record into database.',__FILE__,__LINE__,$db->error());
        return true;
}

Adding it before the "return true;" would probably be the best place, it will only be created after the image/file has been uploaded correctly.

The file will be named: $pun_config['attach_basefolder'].$pun_config['attach_subfolder'].'/'.$unique_name

But I'll see if I make it possible for 1.3 to have this feature added 'afterwards'... as the mod will be rewritten... again

just another type of spam ... the CAPTCHA mod at punres (not sure if it's updated), should take care of these automatically created users ...

Well when I rewrite it to use the extension system, I'll also make it more flexible ... perhaps even so flexible that the mod itself would be possible to extend further with the extension system ...

But I don't make any promises, but I'll try to make it really easy to fiddle with so thisngs like this is possible to add. (it will more or less become the 2nd ground up rewrite of the mod)

IIRC it was added because of the people making false logout links

[url=login.php?action=out]Look at my new site[/url]

Adding that id will make it only to work for one person ... not everyone clicking there...

no security stuff, just to stop annoying things

I don't see any white lines on my IE6 ...

It's the attachment mod, you didn't follow the installationguide, so you replaced one of the changesets made to PunBB.
http://dev.punbb.org/changeset/172

Re-add that changeset, then read the "Installing the mod on PunBB 1.2.6+" at the installation guide over at http://cms.frankh.shacknet.nu/. And redo the attachment mod steps 43 & 44, according to the installation guide.

Edit: it's mentioned in this topic, but the topic description isn't really describing this phenomen, so hard to find, but I knew about it

Edit2: Considering how many that mess up on this I'm thinking of re-doing the readme ... but I really haven't got the time atm ... hmm... ah well, we'll see...